commit ff154bf3a761ec052adf000d198ef13867e809c8 Merge: 47f3c4b 4854e98 Author: Isaque Galdino Date: Mon Jun 5 22:21:49 2017 -0300 Merge branch 'wip/gbsneto/ui-tweaks' commit 4854e98db1198c7f739a76f7d04d877a4b710f8d Author: Georges Basile Stavracas Neto Date: Mon Jun 5 09:26:11 2017 -0300 main-view: Disconnect handlers on dispose Per GObject documentation, the correct place to disconnect from signal handlers is dispose() rather than finalize(). This avoids a few warnings when quitting the application. src/bjb-main-view.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 23a9d21a1a9be95b2bbf6626d80ede3b4a989fda Author: Georges Basile Stavracas Neto Date: Mon Jun 5 09:20:37 2017 -0300 editor-toolbar: Remove accelerators When GtkBuilder is creating the composite template instance, it parses the accelerators and attempts to find the parent toplevel widget to map the accelerators. The problem with this is that the toolbar widget is not added to any toplevel on creation time, and the accel fails to be attached to the non-existant toplevel. This throws a few warnings that can be avoided, since the accels are also set programmatically. Fix these warnings by removing the GtkBuilder accel definitions from editor-toolbar.ui. src/resources/editor-toolbar.ui | 3 --- 1 file changed, 3 deletions(-) commit a405aa0416a6423ff7260088a2198fce4825a8e4 Author: Georges Basile Stavracas Neto Date: Sun Jun 4 12:27:56 2017 -0300 manager, owncloud: Fix reference management References are going crazy! This commit sinks the floating reference of the GtkImage in ownCloud provider before allow using it, and make BijiManager stop unreferencing a dead provider on 'abort'. src/bjb-settings-dialog.c | 2 +- src/libbiji/biji-manager.c | 2 -- src/libbiji/provider/biji-own-cloud-provider.c | 9 +++++---- 3 files changed, 6 insertions(+), 7 deletions(-) commit a0615f40545ac4d9b568d3234c2a9f9470f81db7 Author: Georges Basile Stavracas Neto Date: Sun Jun 4 12:20:17 2017 -0300 selection-toolbar: Add background color The current selection toolbar is invisible and looks very bad. This commit adds a background color to it. src/bjb-selection-toolbar.c | 2 ++ 1 file changed, 2 insertions(+) commit 01a6b40660acec1f7bd001f8884a7073874171d6 Author: Georges Basile Stavracas Neto Date: Sun Jun 4 11:54:58 2017 -0300 settings-dialog: Modernize code The current settings dialog fails in many places, such as constructing the entire UI with code (when the ideal way is to use GtkBuilder files), and it has many design flaws, making it not compilant to the GNOME HIG. This commit updates the code of BjbSettingsDialog in the following forms: * Use G_DECLARE_FINAL_TYPE() and get rid of the boilerplate. * Turn into a composite class, and add a 'settings-dialog.ui' file with all the UI definitions. * Brutally simplify the code. * Fix a couple of issues in the way. src/bjb-settings-dialog.c | 384 +++++++++------------------------------ src/bjb-settings-dialog.h | 29 +-- src/bjb-settings.c | 4 +- src/bjb.gresource.xml | 4 + src/resources/settings-dialog.ui | 182 +++++++++++++++++++ 5 files changed, 276 insertions(+), 327 deletions(-) commit 47f3c4bd81d644f1a13f853cdf54f44cb252f0d2 Author: Isaque Galdino Date: Tue May 30 23:36:31 2017 -0300 note-obj: Convert webkit1 to webkit2 notes After migration to webkit2 API, when user tried to change notes created before the migration, those updates were lost. The issue was related to how old notes were saved, using different html tags for header and javascript enablement, necessary for the webkit-editor window. This code was created to detect a webkit1 note and convert it to webkit2, so webkit-editor won't get lost. https://bugzilla.gnome.org/show_bug.cgi?id=782986 src/libbiji/biji-note-obj.c | 46 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) commit 1778d9e68b17515946218d97f36a4f912fdc2ef8 Author: Jordi Mas Date: Mon May 29 20:27:58 2017 +0200 Update Catalan translation po/ca.po | 153 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 77 insertions(+), 76 deletions(-) commit 5ff688e564ea2d17be4b4836307ce9c27f10c606 Author: Iñigo Martínez Date: Tue May 9 15:47:08 2017 +0200 src: Avoid deprecated gtk_show_uri() Replaced deprecated gtk_show_uri by gtk_show_uri_on_window. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-app-menu.c | 6 +++++- src/libbiji/editor/biji-webkit-editor.c | 27 ++++++++++++++++----------- 2 files changed, 21 insertions(+), 12 deletions(-) commit 79688a38ce6cd4ab876262a2102f97422a92104e Author: Iñigo Martínez Date: Tue May 9 15:45:54 2017 +0200 src: removed trailing whitespaces https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-app-menu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit da294bd800e8fac886039993e12a8d0c0a1e2d53 Author: Iñigo Martínez Date: Tue May 9 15:33:14 2017 +0200 src: Avoid deprecated functions Replaced deprecated gdk_screen_get_monitor_scale_factor and gdk_screen_get_primary_monitor functions by gdk_monitor_get_scale_factor and gdk_display_get_primary_monitor functions. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bijiben-shell-search-provider.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 2b7386a485ea4bef81d5246d96e6f19f71784f0e Author: Iñigo Martínez Date: Tue May 9 15:26:12 2017 +0200 src: add explicit code for missing case The BJB_WINDOW_BASE_NO_VIEW case was covered by the default code. It has been added explicitly. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-window-base.c | 1 + 1 file changed, 1 insertion(+) commit 1f04ac55ca027e9a571ca91d79d67acd0726c056 Author: Iñigo Martínez Date: Tue May 9 15:20:34 2017 +0200 src: Avoid deprecated gtk_tree_view_set_rules_hint https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-organize-dialog.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 0d2a4292283d183e7841bae31cf9e1da5ff2061f Author: Iñigo Martínez Date: Tue May 9 15:18:24 2017 +0200 src: Fixed const qualifier discard message The string field on target_list GtkTargetEntry does not have the const qualifier. A cast has been added to the string literal. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-main-view.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 1b1abc27ba04998439eca3c394100ee293f99c0b Author: Iñigo Martínez Date: Tue May 9 15:08:40 2017 +0200 src: remove some unused constructor codes The biji_main_view_constructor and bjb_window_base_constructor function were calling parent class constructor, which is done by default, so these codes are not needed. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-main-view.c | 13 ------------- src/bjb-window-base.c | 15 --------------- 2 files changed, 28 deletions(-) commit 6e781feb7ce06a13c3d618a0f661beb1f876b34e Author: Iñigo Martínez Date: Tue May 9 15:04:15 2017 +0200 bjb-empty-results-box: add explicit code for missing case The BJB_EMPTY_RESULTS_TYPE case was covered by the default code. It has been added explicitly. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-empty-results-box.c | 1 + 1 file changed, 1 insertion(+) commit 0461a0150d15d844faf0ad98c24f7fce05784a39 Author: Iñigo Martínez Date: Tue May 9 15:02:27 2017 +0200 bjb-main-toolbar: add explicit code for cases covered by default The non explicit cases are covered by the default code. Those cases has been added properly to the code. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-main-toolbar.c | 4 ++++ 1 file changed, 4 insertions(+) commit 45ea3f63580cfbedb22ff781522c3f952078bb03 Author: Iñigo Martínez Date: Sat May 6 12:19:51 2017 +0200 bjb-controller: added not covered cases to switch statements An new case has been created for BIJI_MANAGER_MASS_CHANGE as it was covered inside the default case by checking flag again. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-controller.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit f55eefec841486a448a9f29cae7baaf1440c0b33 Author: Iñigo Martínez Date: Sat May 6 12:02:48 2017 +0200 biji-webkit-editor: Fixed mixed declarations and code https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/libbiji/editor/biji-webkit-editor.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 533c0f6a7207a0a72083734c16ec603784c50804 Author: Iñigo Martínez Date: Sat May 6 12:00:07 2017 +0200 biji-webkit-editor: Fixed toggle block format switch The toggle block format switch has been fixed from not covering all the available options. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/libbiji/editor/biji-webkit-editor.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) commit 5be656f70a2b02acf055112f2762ed6bf5fa7f46 Author: Iñigo Martínez Date: Sat May 6 11:57:30 2017 +0200 biji-editor-selection: Fixed editor set selection switch Fixed editor set selection switch missing default case error. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/libbiji/editor/biji-editor-selection.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 59540468524d86524f51bd08fd7702a38a0aa4b1 Author: Iñigo Martínez Date: Sat May 6 11:39:19 2017 +0200 biji-note-obj: added const qualifier to return type Added const qualifier to biji_note_obj_editor_get_selection function return in order to not discard the const qualifier from biji_webkit_editor_get_selection's return. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/bjb-editor-toolbar.c | 2 +- src/libbiji/biji-note-obj.c | 2 +- src/libbiji/biji-note-obj.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 812448a3c62c3dd17f954a8219b802afc2d693f5 Author: Iñigo Martínez Date: Sat May 6 11:04:31 2017 +0200 manager: declared note changed callback as static The note changed callback has been declared as static to avoid an error issued by missing-prototypes option. https://bugzilla.gnome.org/show_bug.cgi?id=771225 src/libbiji/biji-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9d9e82ca2b545e318a7eed68428cb1d8a9b778e5 Author: Philip Withnall Date: Sun Feb 21 21:40:58 2016 +0000 build: Add AX_COMPILER_FLAGS to standardise compiler warning flags See http://www.gnu.org/software/autoconf-archive/ax_compiler_flags.html. https://bugzilla.gnome.org/show_bug.cgi?id=762648 Signed-off-by: Isaque Galdino configure.ac | 7 ++----- src/Makefile.am | 16 +++++++++++++++- src/libbiji/Makefile.am | 8 ++++++++ 3 files changed, 25 insertions(+), 6 deletions(-) commit be226f1766981915bc0d1a90a249312f2a32349e Author: Isaque Galdino Date: Tue May 2 23:26:08 2017 -0300 output: unwanted log messages Bijiben was throwing some debug messages to console. Those messages were created using g_print, which seems to be create to help some debug process in the past and it was left in the code. Messages were removed from the code. https://bugzilla.gnome.org/show_bug.cgi?id=781127 src/bjb-controller.c | 3 --- src/libbiji/biji-manager.c | 1 - 2 files changed, 4 deletions(-) commit 8485002ad1858d804c8d932a1908cb0cad963ab2 Author: Philip Withnall Date: Thu Apr 27 15:02:58 2017 +0800 src: Add missing cases to switch statements This makes it more explicit about how each element in an enum is handled by the switch. https://bugzilla.gnome.org/show_bug.cgi?id=762648 Signed-off-by: Isaque Galdino src/bjb-main-toolbar.c | 5 ++-- src/libbiji/deserializer/biji-lazy-deserializer.c | 3 +++ src/libbiji/deserializer/biji-tomboy-reader.c | 31 +++++++++++++---------- src/libbiji/editor/biji-editor-selection.c | 12 +++++---- 4 files changed, 29 insertions(+), 22 deletions(-) commit 53783a81b34681f8c27c1b45845e3959d86d40b8 Author: Isaque Galdino Date: Tue Apr 25 01:02:01 2017 -0300 tags: removed tags file from tree src/tags | 29 ----------------------------- 1 file changed, 29 deletions(-) commit 257a48d87dde3347814ecf5a9beee0607334022d Author: Isaque Galdino Date: Tue Apr 25 00:35:25 2017 -0300 note-view: segfault back button Fixed bug introduced in commit 389bb2e29786739b4a9d0199896f070e4ce85cdb which added code to clear editor-toolbar object in the finalization method of note-view. The problem is that, this object is already cleared by its parent container, when their parent window is destroyed. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-note-view.c | 1 - 1 file changed, 1 deletion(-) commit 3ecf0c421564ab13064cf34a8272ca14da671a05 Author: Laurent Bigonville Date: Mon Apr 24 11:29:07 2017 +0800 Fix wrong references to bijiben desktop file Currently, some references to desktop file are written as "bijiben.desktop". While the desktop file in this project is named as "org.gnome.bijiben.desktop". Fix that by changing these references in the search provider and zeitgeist part. https://bugzilla.gnome.org/show_bug.cgi?id=781106 data/org.gnome.bijiben-search-provider.ini | 4 ++-- src/bijiben-shell-search-provider.c | 2 +- src/libbiji/biji-zeitgeist.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) commit 226c8314915e48cfc5414d99fcabde50cdb75ab5 Author: Jonathan Kang Date: Fri Apr 21 10:50:29 2017 +0800 Fix some memory leaks Fix some memory leaks introduced by commit 389bb2e29786739b4a9d0199896f070e4ce85cdb. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-controller.c | 1 - src/libbiji/biji-manager.c | 2 +- src/libbiji/biji-zeitgeist.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) commit a712c3ee087b684da2232043b2ee5aeaab51cb36 Author: Isaque Galdino Date: Sun Apr 23 19:28:57 2017 -0300 doap: add Isaque as a new maintainer bijiben.doap | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit a7d4473cc85a5bff127a0b622c642f0406b234a1 Author: Isaque Galdino Date: Sun Apr 23 19:15:48 2017 -0300 doap: added description tag When it was done a change to bijiben.doap file and it was tried to push that to master, git remote complainted it was missing the "description" tag. This change adds the missing "description" tag. bijiben.doap | 2 ++ 1 file changed, 2 insertions(+) commit f0a5155e2e6e4c121177fdf3caf9eb34b948e9d1 Author: Philip Withnall Date: Wed Feb 24 21:20:45 2016 +0000 src: Remove unused functions https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/libbiji/biji-note-obj.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) commit da9a03e81b181bcb59c4fb9f67ea95ecdb5f296d Author: Philip Withnall Date: Wed Feb 24 21:20:55 2016 +0000 biji-note-obj: Remove duplicate function declaration https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/libbiji/biji-note-obj.h | 3 --- 1 file changed, 3 deletions(-) commit c1d660bf94c1a7e30064e3f96c9bff016cb14c29 Author: Philip Withnall Date: Wed Feb 24 21:20:04 2016 +0000 src: Use #ifdef instead of #if ‘#if’ only works if the variable is defined in the preprocessor (to have value 0 or 1); ‘#ifdef’ works more conventionally. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/libbiji/biji-manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6eda3573ee7d0066687f1863c31c999a2cb4ab18 Author: Philip Withnall Date: Wed Feb 24 21:19:43 2016 +0000 build: Fix include path for libbiji subdirectory This was triggering a compiler warning (and was not being a particularly useful -I flag). https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/libbiji/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c819c0c666e7a632f0dba8a3697deea56318600d Author: Philip Withnall Date: Wed Feb 24 21:17:21 2016 +0000 src: Fix old-style function definitions func() means ‘a function called func which accepts an undefined set of parameters’; whereas func(void) means ‘a function called func which accepts zero parameters’. This allows optimised function calls (not really important here, but not bad to have), allows detection of bad behaviour (like passing parameters to these functions) and shuts up some compiler warnings. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-import-dialog.c | 4 ++-- src/bjb-settings-dialog.c | 4 ++-- src/bjb-window-base.h | 2 +- src/libbiji/biji-info-set.c | 2 +- src/libbiji/biji-info-set.h | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) commit 3f4faecf8f718ea79de61b5fd9dfb51eac6fe571 Author: Philip Withnall Date: Sun Apr 23 21:03:44 2017 +0800 src: Move all declarations to the top of blocks This fixes C90 style, which makes it easier to see all the memory a function allocates or handles throughout its body. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-bijiben.c | 3 ++- src/bjb-import-dialog.c | 4 ++-- src/bjb-main-toolbar.c | 4 +++- src/libbiji/biji-manager.c | 6 +++--- src/libbiji/biji-note-obj.c | 12 ++++++++---- src/libbiji/editor/biji-webkit-editor.c | 12 +++++++----- src/libbiji/provider/biji-import-provider.c | 10 ++++------ src/libbiji/provider/biji-memo-provider.c | 3 +-- 8 files changed, 30 insertions(+), 24 deletions(-) commit e971a0b914ec407d644cce8bde213b2f91277ea3 Author: Philip Withnall Date: Sun Apr 23 18:37:42 2017 +0800 src: Various const-correctness fixes This makes it clearer about which bits of code have ownership of which bits of memory, and also shut up compiler warnings about discarding const modifiers from variables. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-color-button.c | 14 +++++------ src/bjb-empty-results-box.c | 3 ++- src/bjb-import-dialog.c | 6 ++--- src/bjb-main-view.c | 4 ++-- src/bjb-note-view.c | 3 ++- src/bjb-share.c | 32 +++++++++++++------------- src/libbiji/biji-date-time.c | 8 +++---- src/libbiji/biji-date-time.h | 8 +++---- src/libbiji/biji-error.c | 2 +- src/libbiji/biji-error.h | 2 +- src/libbiji/biji-note-obj.c | 2 +- src/libbiji/biji-note-obj.h | 2 +- src/libbiji/biji-string.c | 10 ++++---- src/libbiji/biji-string.h | 8 +++---- src/libbiji/biji-zeitgeist.c | 2 +- src/libbiji/biji-zeitgeist.h | 8 +++---- src/libbiji/provider/biji-import-provider.c | 2 +- src/libbiji/provider/biji-local-provider.c | 4 ++-- src/libbiji/provider/biji-own-cloud-provider.c | 2 +- src/libbiji/serializer/biji-lazy-serializer.c | 4 +++- 20 files changed, 66 insertions(+), 60 deletions(-) commit d3a8ba13bb6dfbdaa8a03f35c649c76f7b4b5252 Author: Jonathan Kang Date: Thu Apr 20 20:06:55 2017 +0800 bjb-bijiben: initialize "remaining" as NULL "remaining" variable is not initialized as NULL. Fix that by initializing it as NULL. Fix commit 0c5e079ca1a3c323c6d1c99603ff06f10c535fed. src/bjb-bijiben.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d5ea367ddf3ad1c0aa430a8ae5a264425b7059d6 Author: Ting-Wei Lan Date: Tue Jun 14 03:29:39 2016 +0800 Remove useless vim swap file src/libbiji/.Makefile.am.swp is useless and shouldn't be included to the git repository. https://bugzilla.gnome.org/show_bug.cgi?id=780937 src/libbiji/.Makefile.am.swp | Bin 12288 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) commit e5426be522533772a170a8d7aa5d64b40321ebf0 Author: Iñigo Martínez Date: Thu Apr 20 10:43:18 2017 +0800 build: Fixed typo when compiling resources Fix commit 0248bf87164a23f8ff9cd80b31c25af11e92ca53. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 2ec0b0c4d8c3b273d37f2708e1c2bc7da418c07c Author: Philip Withnall Date: Wed Apr 19 17:33:31 2017 +0800 src: Mark various internal functions as static This will provide slight optimisations when linking, but mostly just shuts up compiler warnings about functions being defined before they’re declared. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bijiben-shell-search-provider.c | 8 +++---- src/bjb-main-toolbar.c | 8 +++---- src/bjb-main-view.c | 18 +++++++-------- src/bjb-settings-dialog.c | 6 ++--- src/libbiji/biji-note-obj.c | 8 +++---- src/libbiji/deserializer/biji-lazy-deserializer.c | 28 +++++++++++------------ src/libbiji/provider/biji-import-provider.c | 2 +- src/libbiji/provider/biji-local-note.c | 8 +++---- src/libbiji/provider/biji-local-provider.c | 2 +- src/libbiji/provider/biji-memo-note.c | 2 +- src/libbiji/provider/biji-memo-provider.c | 8 +++---- src/libbiji/provider/biji-own-cloud-note.c | 4 ++-- src/libbiji/provider/biji-own-cloud-provider.c | 4 ++-- src/libbiji/serializer/biji-lazy-serializer.c | 20 ++++++++-------- 14 files changed, 63 insertions(+), 63 deletions(-) commit 471810c6a1bb9dd9825649520fe16228f0be0972 Author: Philip Withnall Date: Wed Apr 19 17:04:18 2017 +0800 src: Various const-correctness fixes This helps clarify the memory management in several places, but is by no means complete. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-settings.c | 6 +++--- src/bjb-settings.h | 6 +++--- src/libbiji/biji-manager.c | 20 ++++++++++---------- src/libbiji/biji-manager.h | 20 ++++++++++---------- src/libbiji/biji-note-id.c | 9 +++++---- src/libbiji/biji-note-id.h | 8 ++++---- src/libbiji/biji-note-obj.c | 13 ++++++++----- src/libbiji/biji-note-obj.h | 19 ++++++++++--------- src/libbiji/provider/biji-import-provider.c | 14 ++++++++------ src/libbiji/provider/biji-import-provider.h | 12 ++++++------ src/libbiji/provider/biji-local-note.c | 8 ++++---- src/libbiji/provider/biji-local-provider.c | 18 +++++++++--------- src/libbiji/provider/biji-memo-note.c | 7 ++++--- src/libbiji/provider/biji-memo-note.h | 2 +- src/libbiji/provider/biji-memo-provider.c | 4 ++-- src/libbiji/provider/biji-own-cloud-note.c | 8 ++++---- src/libbiji/provider/biji-own-cloud-provider.c | 14 +++++++------- src/libbiji/provider/biji-provider.h | 18 +++++++++--------- 18 files changed, 107 insertions(+), 99 deletions(-) commit 389bb2e29786739b4a9d0199896f070e4ce85cdb Author: Philip Withnall Date: Wed Apr 19 15:49:28 2017 +0800 Fix some memory leaks There are still some remaining, but for a first pass of very basic startup and editing functionality, this has eliminated several memory leaks. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/bjb-controller.c | 3 +++ src/bjb-note-view.c | 1 + src/bjb-settings.c | 35 +++++++++++++++----------- src/libbiji/biji-manager.c | 21 ++++++++++------ src/libbiji/biji-tracker.c | 14 +++++++---- src/libbiji/biji-zeitgeist.c | 26 +++++++++++-------- src/libbiji/provider/biji-memo-provider.c | 19 ++++++++++---- src/libbiji/provider/biji-own-cloud-provider.c | 16 +++++++++--- 8 files changed, 89 insertions(+), 46 deletions(-) commit 488efe9ae2b2e569860dd2cdf145ba8b421944aa Author: Philip Withnall Date: Sat Feb 20 14:39:13 2016 +0000 build: Use AC_PATH_PROG to look up gdbus-codegen https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 1 + src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit e20e922964bcae3c35c5f5d5e0250a1eb6619020 Author: Philip Withnall Date: Wed Apr 19 14:51:05 2017 +0800 build: Remove explicit -Wall -g from AM_CFLAGS These are developer options which should be set by specific developers in their local CFLAGS environment variable, otherwise they enter production builds. The ultimate solution to this is to use AX_COMPILER_FLAGS to set the default set of compiler flags. See http://www.gnu.org/software/autoconf-archive/ax_compiler_flags.html. https://bugzilla.gnome.org/show_bug.cgi?id=762648 src/Makefile.am | 9 --------- src/libbiji/Makefile.am | 5 ----- 2 files changed, 14 deletions(-) commit 0248bf87164a23f8ff9cd80b31c25af11e92ca53 Author: Philip Withnall Date: Tue Apr 18 22:02:56 2017 +0800 build: Tidy up glib-compile-resources usage in Makefile.am Use $(AM_V_GEN), calculate dependencies automatically, and use nodist_bijiben_SOURCES correctly to ensure generated sources are not distributed. This means the dist-hook can be removed. https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 2 ++ src/Makefile.am | 40 +++++++++++++++++----------------------- 2 files changed, 19 insertions(+), 23 deletions(-) commit 0989cbe04912ab0764c9e5f484b104e8a5243f1d Author: Philip Withnall Date: Tue Apr 18 21:41:18 2017 +0800 build: Check for libm at configure time You cannot rely on -lm being the correct way to link the maths library, as it might be provided by libc on some systems. https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 2 ++ src/Makefile.am | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit 4771f37fc0e0bc6d123fb5f6f6efefed025a0b27 Author: Philip Withnall Date: Tue Apr 18 21:33:12 2017 +0800 build: Fix quoting in configure.ac https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 45 +++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 22 deletions(-) commit f71d83f88f29b368504903c4cf13f4dd4ae8d119 Author: Philip Withnall Date: Sat Feb 20 14:06:48 2016 +0000 build: Use LT_INIT instead of AM_PROG_LIBTOOL AM_PROG_LIBTOOL has been deprecated for a long time. https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit abe9205e1308cdba3aa1140482f1ee1596a9ed2a Author: Philip Withnall Date: Sat Feb 20 14:05:11 2016 +0000 build: Use AS_HELP_STRING instead of AC_HELP_STRING AC_HELP_STRING has been deprecated for a long time. https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 708a1304340ec89836f22d83c71125db411b7aa8 Author: Philip Withnall Date: Sat Feb 20 14:04:30 2016 +0000 build: Remove GNOME_DOC_PREPARE macro usage This macro was removed from gnome-common a long time ago, and relates to the antique GNOME documentation infrastructure. Bijiben already uses Yelp. https://bugzilla.gnome.org/show_bug.cgi?id=762648 configure.ac | 3 --- 1 file changed, 3 deletions(-) commit 4fadc068a21528b1e07970132648d4a067289929 Author: Philip Withnall Date: Sat Feb 20 14:00:40 2016 +0000 build: Remove use of AM_GLIB_GNU_GETTEXT Bijiben is already using intltool; you cannot use both at once. https://bugzilla.gnome.org/show_bug.cgi?id=762648 autogen.sh | 1 - configure.ac | 1 - 2 files changed, 2 deletions(-) commit 9a93421b25824dff19a1c2485461759654012ca4 Author: Philip Withnall Date: Sat Feb 20 13:59:02 2016 +0000 build: Remove gnome-common dependency from autogen.sh gnome-common has been completely deprecated. See https://wiki.gnome.org/Projects/GnomeCommon/Migration. Fix that by removing gnome-common dependency from autogen.sh. https://bugzilla.gnome.org/show_bug.cgi?id=762648 autogen.sh | 44 ++++++++++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 14 deletions(-) commit ea3610066fd643f8fb7c5317721ef1dcb0bd6325 Author: Isaque Galdino Date: Fri Mar 17 10:28:27 2017 -0300 note-view: Fix background color Background color was not being used in text view/editor. The code to actually set the background was not even there. After fixing that, as a side effect, it also fixed the text editor which was messing up all text during text edition. https://bugzilla.gnome.org/show_bug.cgi?id=761765 src/bjb-note-view.c | 3 +++ 1 file changed, 3 insertions(+) commit fb7b8bbac5ef3591d2f940f3034a4390468ad01d Author: Carlos Garcia Campos Date: Wed Mar 9 11:17:41 2016 +0100 Port to WebKit2 https://bugzilla.gnome.org/show_bug.cgi?id=728293 configure.ac | 3 +- data/Default.css | 2 +- data/Makefile.am | 8 +- data/bijiben.js | 80 +++++ src/bjb-main-toolbar.c | 6 +- src/bjb-note-view.c | 14 +- src/bjb-window-base.c | 10 +- src/libbiji/Makefile.am | 2 - src/libbiji/biji-note-obj.c | 9 +- src/libbiji/editor/biji-editor-selection.c | 337 +++---------------- src/libbiji/editor/biji-editor-selection.h | 19 +- src/libbiji/editor/biji-editor-utils.c | 55 --- src/libbiji/editor/biji-editor-utils.h | 26 -- src/libbiji/editor/biji-webkit-editor.c | 516 ++++++++++++++++------------- src/libbiji/editor/biji-webkit-editor.h | 7 +- 15 files changed, 449 insertions(+), 645 deletions(-) commit d74e55ac1fb7c865c0d57368da5a94a45a60bcd6 Author: Carlos Garcia Campos Date: Mon Mar 7 14:04:00 2016 +0100 editor: Remove unused code in preparation for WebKit2 port I don't know why there's so much unused code, we can bring it back from git history if needed eventually, but at the moment it doesn't make sense to port unused code to WebKit2, since we can't even test it. https://bugzilla.gnome.org/show_bug.cgi?id=728293 src/libbiji/editor/biji-editor-selection.c | 1069 +--------------------------- src/libbiji/editor/biji-editor-selection.h | 112 +-- src/libbiji/editor/biji-editor-utils.c | 35 - src/libbiji/editor/biji-editor-utils.h | 2 - src/libbiji/editor/biji-webkit-editor.c | 6 - 5 files changed, 27 insertions(+), 1197 deletions(-) commit eba32065aa8dee2a2c0404118d765097b1f44c18 Author: Marek Černocký Date: Thu Mar 23 20:04:15 2017 +0100 Updated Czech translation po/cs.po | 155 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 78 insertions(+), 77 deletions(-) commit aee57fbd3b0a606ba9f8f75b8d6a8468b0421118 Author: Andika Triwidada Date: Sun Mar 19 10:20:31 2017 +0000 Update Indonesian translation po/id.po | 132 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 67 insertions(+), 65 deletions(-) commit 50c9fae34950f2f4666fcbc8d9699707182ee675 Author: Baurzhan Muftakhidinov Date: Sun Mar 12 03:24:03 2017 +0000 Update Kazakh translation po/kk.po | 155 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 77 insertions(+), 78 deletions(-) commit 4fe18d533324570754364441bcd8c05da87f456d Author: Aurimas Černius Date: Fri Mar 10 22:20:22 2017 +0200 Updated Lithuanian translation po/lt.po | 135 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 67 insertions(+), 68 deletions(-) commit 39281eaac3a095ba3c7aa45631cfb10aa578a8a6 Author: Iñigo Martínez Date: Sun Mar 5 22:37:53 2017 +0100 bjb-bijiben: improved how files opening is handled On one hand file paths were converted back and forth to GFiles, on the other hand paths were removed and added to the files_to_open queue. The code has been refactorized to avoid this and the files_to_open has been changed to a static variable to avoid a memory allocation. src/bjb-bijiben.c | 153 ++++++++++++++++++++---------------------------------- 1 file changed, 56 insertions(+), 97 deletions(-) commit 0c5e079ca1a3c323c6d1c99603ff06f10c535fed Author: Iñigo Martínez Date: Sun Mar 5 22:32:52 2017 +0100 bjb-bijiben: fixed two memory leaks If the remaining variable contains data, it is not freed if the code jumps to the out label. If there is no remaining data, files will remain with NULL. In that case there is an allocation that is not freed as the code jumps to the out label. src/bjb-bijiben.c | 57 +++++++++++++++---------------------------------------- 1 file changed, 15 insertions(+), 42 deletions(-) commit 45c1b937aae1b28024cafccfe61d2c8e05d8ac06 Author: Alexandre Franke Date: Thu Mar 2 08:34:41 2017 +0100 Update French translation help/fr/figures/notes-3-12.png | Bin 0 -> 34824 bytes help/fr/figures/notes-scr.png | Bin 57819 -> 0 bytes help/fr/fr.po | 45 ++++++++++++++++++++++------------------- 3 files changed, 24 insertions(+), 21 deletions(-) commit bff3cc849ca05d6017620ee9849888e84a963a71 Author: Isaque Galdino Date: Wed Mar 1 15:04:32 2017 -0300 build: Remove dependancy on libedataserverui libedataserverui depends on WebKit2 and Bijiben is still on WebKit1, so in order to prevent naming clash between the those libraries we need to remove it, until Bibijen is ported to WebKit2. configure.ac | 1 - 1 file changed, 1 deletion(-) commit cd0523d843674581b919a48a09368a3f25f8c757 Author: Anders Jonsson Date: Wed Mar 1 10:38:22 2017 +0000 Update Swedish translation po/sv.po | 197 +++++++++++++++++++++++++++++++++------------------------------ 1 file changed, 103 insertions(+), 94 deletions(-) commit 3697f368c09e75e73fd93ecbb248a96ede527879 Author: Ting-Wei Lan Date: Tue Jun 14 03:31:19 2016 +0800 build: Allow build in non-srcdir https://bugzilla.gnome.org/show_bug.cgi?id=767620 src/Makefile.am | 1 + src/libbiji/provider/biji-provider.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit a28cf11b18acbaf2957ba7bbc7edf38145646c77 Author: Piotr Drąg Date: Sun Feb 26 17:52:58 2017 +0100 Update Polish translation po/pl.po | 107 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 54 insertions(+), 53 deletions(-) commit 0553bea66abbcad290f4ee4df021e50d6b1adf40 Author: Мирослав Николић Date: Sun Feb 26 15:58:27 2017 +0100 Updated Serbian translation po/sr.po | 158 ++++++++++++++++++++++++++++---------------------------- po/sr@latin.po | 160 ++++++++++++++++++++++++++++----------------------------- 2 files changed, 157 insertions(+), 161 deletions(-) commit 9b6177ff97bfbbd045e4c4f21894fee63930fd2d Author: Piotr Drąg Date: Sun Feb 26 01:57:39 2017 +0100 bjb-editor-toolbar: fix wrong tooltip src/resources/editor-toolbar.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8dcfc7901af970b980e8ec9b0331194456e9eea0 Author: Piotr Drąg Date: Sun Feb 26 01:54:06 2017 +0100 Update POTFILES.in po/POTFILES.in | 1 + 1 file changed, 1 insertion(+) commit 8811ff5003a1129550b2f522a80cd302e91b05e8 Author: Iñigo Martínez Date: Sat Feb 25 23:34:25 2017 +0100 bjb-editor-toolbar: moved UI definition to a template file. The UI definition and implementation has been split by moving the former to a template file. The code has also been updated by using GTK facilities for class definitions. https://bugzilla.gnome.org/show_bug.cgi?id=728859 src/Makefile.am | 1 + src/bjb-editor-toolbar.c | 460 ++++++++++++++++++---------------------- src/bjb-editor-toolbar.h | 26 +-- src/bjb.gresource.xml | 1 + src/resources/editor-toolbar.ui | 219 +++++++++++++++++++ 5 files changed, 430 insertions(+), 277 deletions(-) commit 81a8fe5245119663f15edb32aebaf9ebe3be5306 Author: Iñigo Martínez Date: Sat Feb 25 23:28:35 2017 +0100 bjb-editor-toolbar: moved from GtkPopover to GtkActionBar Popover approach had placement issues so it has been converted to a GtkActionBar following one of the proposals from the GNOME Desing team. https://bugzilla.gnome.org/show_bug.cgi?id=728859 src/bjb-editor-toolbar.c | 374 ++++++++++++++--------------------------------- src/bjb-editor-toolbar.h | 12 +- src/bjb-note-view.c | 24 +-- src/bjb-window-base.c | 2 +- 4 files changed, 129 insertions(+), 283 deletions(-) commit 4b50e3b650fa2da87b7ac216d9199a9405f975c3 Author: Ask Hjorth Larsen Date: Thu Feb 16 13:33:05 2017 +0100 Updated Danish translation po/da.po | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) commit 7672cbc0a2655b0763e3bb8f1179217a96ff22c8 Author: Piotr Drąg Date: Thu Jan 26 04:25:11 2017 +0100 Fix a translator comment They need to be exactly one line above a string to show up in .po files. src/bjb-bijiben.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 774ebde9425e77deb10f75b8f05138736d0655d6 Author: Yuri Myasoedov Date: Wed Sep 28 11:18:31 2016 +0300 Updated Russian traslation po/ru.po | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 61349d99d5f8b42d723b6cb2b54339d041238a20 Author: Alexandre Franke Date: Mon Sep 19 08:47:46 2016 +0000 Updated French translation help/fr/fr.po | 41 +++++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 18 deletions(-) commit 21a54c34cca3d1f1cb0a4df4f6dd88a30247b7a5 Author: E T Date: Wed Sep 14 21:05:14 2016 +0000 Updated Turkish translation po/tr.po | 94 +++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 48 insertions(+), 46 deletions(-) commit a1d5b99e6b0003bd21d30ce00c4bae9b5a5d8feb Author: Arash Mousavi Date: Fri Sep 9 17:01:30 2016 +0430 [l10n] add Persian translations po/LINGUAS | 1 + po/fa.po | 485 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 486 insertions(+) commit 893e91af02883f9120eccc9894296eef826ed62d Author: Rafael Fontenelle Date: Tue Sep 6 05:05:46 2016 +0000 Updated Brazilian Portuguese translation help/pt_BR/pt_BR.po | 62 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 36 insertions(+), 26 deletions(-) commit 7fc6c5aafd8a619201a1be826fcfe4532dcc4de3 Author: Piotr Drąg Date: Tue Sep 6 04:55:59 2016 +0200 Updated Polish translation po/pl.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit d826c5f03fcb985f1fa49af9d7972b3630a195b2 Author: Mario Blättermann Date: Mon Sep 5 11:56:44 2016 +0000 Updated German translation help/de/de.po | 112 +++++++++++++++++++++++----------------------------------- 1 file changed, 44 insertions(+), 68 deletions(-) commit 9ffdc95d947630625d4a43ed89b0b41f3ab153af Author: Marek Černocký Date: Sun Sep 4 23:17:58 2016 +0200 Updated Czech translation help/cs/cs.po | 51 +++++++++++++++++++++++++++------------------------ 1 file changed, 27 insertions(+), 24 deletions(-) commit 890a954a3b9f6f23f6f4e929bf09a10cf4bf09a7 Author: Seong-ho Cho Date: Sat Sep 3 09:41:10 2016 +0000 Updated Korean translation help/ko/ko.po | 51 +++++++++++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 22 deletions(-) commit 032c159c8b50bda88e5dfa0ebbad2eb5aa165c3d Author: Bruce Cowan Date: Mon Aug 29 12:25:13 2016 +0000 Added British English translation po/LINGUAS | 1 + po/en_GB.po | 481 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 482 insertions(+) commit 78b7e870f5128e3ebacf4875d42c68f060e59dc0 Author: Ask Hjorth Larsen Date: Fri Aug 26 03:43:27 2016 +0200 Updated Danish translation po/da.po | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit 95f00da1cb4bb3eb7bb17597e31b3ee628a26df5 Author: Piotr Drąg Date: Mon Aug 22 15:07:20 2016 +0200 Updated Polish translation po/pl.po | 56 ++++++++++++++++++++++++++------------------------------ 1 file changed, 26 insertions(+), 30 deletions(-) commit 3679c4ee58c3a6539ef76512c7ec933936064a45 Author: Balázs Úr Date: Fri Aug 19 20:32:24 2016 +0000 Updated Hungarian translation help/hu/hu.po | 83 +++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 46 insertions(+), 37 deletions(-) commit 31995d033ba2db0639efb72c710a11e4980f1d62 Author: Daniel Mustieles Date: Tue Aug 2 16:41:29 2016 +0200 Updated Spanish translation po/es.po | 79 ++++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 40 insertions(+), 39 deletions(-) commit 6d57a8aeee046da57cd86d7a9e467a851e03ec3a Author: Piotr Drąg Date: Thu Jul 14 20:48:52 2016 +0200 Add Language headers to po files Future versions of gettext will fail if this header is missing. po/ca@valencia.po | 2 +- po/en_AU.po | 2 +- po/nb.po | 2 +- po/ne.po | 2 +- po/sl.po | 2 +- po/sr@latin.po | 2 +- po/tr.po | 2 +- po/zh_HK.po | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) commit f256b683a2b7b35b3ec949f5ef0470a1792f8f2f Author: Daniel Mustieles Date: Mon Jun 27 14:13:13 2016 +0000 Updated Spanish translation help/es/es.po | 1617 +++++++++++++++++++++++++++++---------------------------- 1 file changed, 815 insertions(+), 802 deletions(-) commit baab416de17927a3658b889ce611b80cc8d4a835 Author: Pierre-Yves Luyten Date: Mon May 30 21:47:59 2016 +0200 3.21.2 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 0e161604eddc3d749e21eeb59a80982f56cb07f5 Author: Cédric Valmary Date: Mon May 30 16:06:04 2016 +0000 Updated Occitan translation po/oc.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 075589bb5ce1eba38e596fe7a475a92912c1baf8 Author: Trần Ngọc Quân Date: Mon May 30 07:52:12 2016 +0700 Updated Vietnamese translation Signed-off-by: Trần Ngọc Quân po/vi.po | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-)